Skip to content

fix(runtime-core):transition missing root node warning used in prod #6752 #6783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

fix(runtime-core):transition missing root node warning used in prod #6752 #6783

wants to merge 25 commits into from

Conversation

baiwusanyu-c
Copy link
Member

close: #6752

chenzhihui and others added 16 commits September 30, 2022 11:38
fix(runtime-core):transition missing root node warning used in prod v…
b8b68a9 
…uejs#6752
@baiwusanyu-c
Merge branch 'vuejs:main' into bwsy/fix/componentRenderUtils
c513858
@baiwusanyu-c
Merge branch 'vuejs:main' into bwsy/fix/componentRenderUtils
8af0965
@baiwusanyu-c
Merge branch 'vuejs:main' into bwsy/fix/componentRenderUtils
7eaaf7e
@baiwusanyu-c
Merge branch 'vuejs:main' into bwsy/fix/componentRenderUtils
eecbcce
@baiwusanyu-c
Merge branch 'vuejs:main' into bwsy/fix/componentRenderUtils
cc75f49
@baiwusanyu-c
Merge remote-tracking branch 'origin/main' into bwsy/fix/componentRen…
bae960d 
…derUtils
@baiwusanyu-c
Merge branch 'vuejs:main' into bwsy/fix/componentRenderUtils
085ad8a
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
9c33f93
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
22be5fb
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
01ccd6f
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
ba61d3b
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
8f942b1
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
c490ad4
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
961c8c1
@baiwusanyu-c
Merge branch 'main' into bwsy/fix/componentRenderUtils
0ab3367
@vercel
Copy link

vercel bot commented Apr 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
sfc-playground ⬜️ Ignored (Inspect) Apr 6, 2023 0:44am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 91.3 kB (+1.84 kB) 34.8 kB (+810 B) 31.4 kB (+678 B)
vue.global.prod.js 148 kB (+1.84 kB) 54 kB (+731 B) 48.2 kB (+634 B)

Usages

Name Size Gzip Brotli
createApp 51.7 kB (+1.91 kB) 20.3 kB (+812 B) 18.5 kB (+699 B)
createSSRApp 55.1 kB (+1.91 kB) 21.7 kB (+827 B) 19.8 kB (+783 B)
defineCustomElement 54 kB (+1.91 kB) 21.1 kB (+817 B) 19.2 kB (+689 B)
overall 65.1 kB (+1.84 kB) 25.2 kB (+799 B) 22.9 kB (+682 B)

@skirtles-code
Copy link
Contributor

I don't think this is the right fix.

Rather than adding a warning, it should ignore the comment in production, same as during dev.

It's possible that #6238 or #7387 will already fix this problem, though I think those PRs still need more work before they can be merged.

@yyx990803 yyx990803 closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: transition
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEV_ROOT_FRAGMENT patchFlag is set despite compilerOptions.comments = true
4 participants
@baiwusanyu-c @skirtles-code @yyx990803 @haoqunjiang